Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#if defined(DEBUG) && DEBUG compiling error #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#if defined(DEBUG) && DEBUG compiling error #380

wants to merge 1 commit into from

Conversation

godera
Copy link

@godera godera commented Jun 8, 2015

replaced by #ifdef DEBUG

@ccgus
Copy link
Owner

ccgus commented Jun 17, 2015

What's the compiler error?

@phoney
Copy link

phoney commented Oct 17, 2015

Actually, IMO both are wrong. Proper use of DEBUG should be
#if DEBUG
This avoids the problem of #define DEBUG 0
Having said that, the proposed fix doesn't fix any compiler warnings that I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godera @ccgus @phoney