Correct validation of numeric input when using a comma as a decimal s…

…eparator (GitHub Issue #77)

changelog.adoc

@@ -27,6 +27,7 @@
 * Write and replace for bxds and xml files to protect against corruption if a crash occurs during a save.
 
 == Release 3.0.3
+* 04/01/2019 Enhanced error handling for relational database to make identification of errors easier.
 * 04/01/2019 Correct validation of numeric input when using a comma as a decimal separator (GitHub Issue #77)
 
 == Release 3.0.2

jgnash-core/src/main/java/jgnash/engine/jpa/AbstractJpaDAO.java

@@ -28,6 +28,7 @@
 
 import javax.persistence.EntityManager;
 import javax.persistence.NoResultException;
+import javax.persistence.PersistenceException;
 
 import jgnash.engine.StoredObject;
 import jgnash.engine.concurrent.PriorityThreadPoolExecutor;
@@ -111,6 +112,9 @@ <T extends StoredObject> T merge(final T object) {
                     em.getTransaction().commit();
 
                     return mergedObject;
+                } catch (final PersistenceException | IllegalStateException  e1) {
+                    logSevere(AbstractJpaDAO.class, e1);
+                    return null;
                 } finally {
                     emLock.unlock();
                 }
@@ -128,6 +132,7 @@ <T extends StoredObject> T merge(final T object) {
      * Persists an object.
      *
      * @param objects {@link Object} to persist
+     * @return {@code true} if successful, {@code false} otherwise
      */
     boolean persist(final Object... objects) {
         boolean result = false;
@@ -146,15 +151,18 @@ boolean persist(final Object... objects) {
                     em.getTransaction().commit();
 
                     return true;
+                } catch (final PersistenceException | IllegalStateException  e1) {
+                    logSevere(AbstractJpaDAO.class, e1);
+                    return false;
                 } finally {
                     emLock.unlock();
                 }
             });
 
             result = future.get();  // block and return
 
-        } catch (final InterruptedException | ExecutionException e) {
-            logSevere(AbstractJpaDAO.class, e);
+        } catch (final InterruptedException | ExecutionException e2) {
+            logSevere(AbstractJpaDAO.class, e2);
             Thread.currentThread().interrupt();
         }