Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edf version #1189

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Update edf version #1189

merged 2 commits into from
Jan 29, 2025

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Jan 28, 2025

Should fix #1188

See related:

NeuralEnsemble/python-neo#1635
SpikeInterface/spikeinterface#3644

I don't think this needs a changelog.

@h-mayorquin h-mayorquin self-assigned this Jan 28, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review January 28, 2025 22:59
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @h-mayorquin!

@pauladkisson pauladkisson merged commit 0668a6c into main Jan 29, 2025
45 of 49 checks passed
@pauladkisson pauladkisson deleted the cap_edf_lib branch January 29, 2025 17:24
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (96dfdff) to head (a434275).
Report is 27 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   90.69%   89.58%   -1.11%     
==========================================
  Files         129      129              
  Lines        8189     8357     +168     
==========================================
+ Hits         7427     7487      +60     
- Misses        762      870     +108     
Flag Coverage Δ
unittests 89.58% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spikeinterface is causing Dev Tests to fail
2 participants