Update epacamd_eia to properly use latest version #478
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
previously approved these changes
Nov 14, 2024
| """Get latest version from our forked repo.""" | ||
| resources = [] | ||
| for year in [2021, 2023]: | ||
| url = f"https://github.com/catalyst-cooperative/camd-eia-crosswalk-latest/archive/refs/tags/v{year}.zip" |
There was a problem hiding this comment.
If we're not just pulling from main and are going to refer to these past tags we should make sure we document that in the README for our fork of the crosswalk repo, so we don't forget next time someone goes in to update it.
There was a problem hiding this comment.
Are the changes not cumulative? Does the 2023 update only cover 2023, and the 2021 update only covers 2021? What happens to the 2022 data? Or the 2019-2020 data?
|
Whoops I meant to comment not approve. |
|
@zschira Do you think there's a short path to getting this into shape for doing annual updates? |
|
@zschira Do you want me to pick up and finish this PR? |
e-belfer
dismissed
zaneselvans’s stale review
Will make major changes to this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor update to
epacamd_eiato use latest year of data instead of pinning to 2021.Out of scope: