Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogFactory - Removed explicit loading of nlog.config by default #419

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Deprecations:

Enhancements:
- Recognize read-only parameters by the `In` modreq (@zvirja, #406)
- NLogFactory and ExtendedNLogFactory default constructor will no longer load NLog.config, since NLog does it automatically (@snakefoot, #419)

## 4.3.1 (2018-06-21)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,14 @@ public class ExtendedNLogFactory : AbstractExtendedLoggerFactory
{
/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// Configures NLog with a config file name 'nlog.config'
/// <seealso cref="Create(string)" />
/// </summary>
public ExtendedNLogFactory()
: this(NLogFactory.defaultConfigFileName)
: this(true)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class with the configfile specified by <paramref
/// name="configFile" />
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// </summary>
/// <param name="configFile"> The config file. </param>
public ExtendedNLogFactory(string configFile)
Expand All @@ -50,7 +47,7 @@ public ExtendedNLogFactory(string configFile)
/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// </summary>
/// <param name="configuredExternally"> If <c>true</c> . Skips the initialization of log4net assuming it will happen externally. Useful if you're using another framework that wants to take over configuration of NLog. </param>
/// <param name="configuredExternally">If <c>true</c>. Skips the initialization of NLog assuming it will happen externally (or automatically by NLog).</param>
public ExtendedNLogFactory(bool configuredExternally)
{
if (configuredExternally)
Expand Down
4 changes: 2 additions & 2 deletions src/Castle.Services.Logging.NLogIntegration/NLogFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ public class NLogFactory : AbstractLoggerFactory
/// Initializes a new instance of the <see cref="NLogFactory" /> class.
/// </summary>
public NLogFactory()
: this(defaultConfigFileName)
: this(true)
snakefoot marked this conversation as resolved.
Show resolved Hide resolved
{
}

/// <summary>
/// Initializes a new instance of the <see cref="NLogFactory" /> class.
/// </summary>
/// <param name="configuredExternally">If <c>true</c>. Skips the initialization of log4net assuming it will happen externally. Useful if you're using another framework that wants to take over configuration of NLog.</param>
/// <param name="configuredExternally">If <c>true</c>. Skips the initialization of NLog assuming it will happen externally (or automatically by NLog).</param>
public NLogFactory(bool configuredExternally)
{
if (configuredExternally)
Expand Down