Remove obsoleted tests and platformDir from Paparazzi config #1457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically,
Environment.platformDir
referencedbuild.prop
and the framework resources bundled under the corresponding$ANDROID_HOME/platforms/$VERSION/
directory.Now that we've migrated to Google's layoutlib published artifacts,
build.prop
is provided bylayoutlib-runtime
and the framework resources bylayoutlib-resources
, removing the need forEnvironment.platformDir
.Consequently, four plugin tests are obsoleted and removed:
$ANDROID_HOME/platforms/$VERSION/
folder is detected (by @luis-cortes)This last bullet point is important. In the past, if the IDE release of LayoutLib did not yet support a given Android SDK level, Paparazzi provided a limited escape hatch to allow the developer to downgrade the platform SDK used by Paparazzi like so:
Here's a recent example of this: #1288 (comment)
With the move to Google's Layoutlib, this facility is no longer available. Still, it's likely (hopeful?) that Google will publish LayoutLib versions often enough (i.e., faster than the IDE release cycle) to allow quicker adoption of newer SDK levels in Paparazzi.