forked from usnistgov/CASE-Utilities-Python
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.12.0 #125
Merged
Merged
Release 0.12.0 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * RDFLib/pySHACL#89 Signed-off-by: Alex Nelson <[email protected]>
Release 0.11.0
I stumbled across this being a potential point of confusion in the Exifread mapping repository's PR 21. References: * casework/CASE-Implementation-PyPI-Exifread#21 Signed-off-by: Alex Nelson <[email protected]>
This sets `case-utils` and downstream Python tooling to take care in reviewing new RDFLib releases for breaking changes. RDFLib Issue 2402 and Discussion 2395 outline an upcoming development period for RDFLib that may see more frequent SEMVER-major version releases. References: * RDFLib/rdflib#2402 Signed-off-by: Alex Nelson <[email protected]>
…_ceilings Start specifying RDFLib version ceilings
This patch partially implements a small piece of PR 118. References: * #118 Requested-by: kchason <[email protected]> Signed-off-by: Alex Nelson <[email protected]>
Use typing symbols directly
AJN: This is a partial application of @kchason 's work in PR 118, and is being pulled into its own patch series to focus review. References: * #118 Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
As spelled before this patch, the doctests were running after the more time-consuming `case_utils` descent. This lets the tests be called on their own, and also lets a failing doctest fail the CI job quicker. Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
It seems to me like `--disallow-untyped-defs`, enabled in `mypy --strict`, should have flagged this as an error. However, from documentation on `no-untyped-def`, `mypy` only requires `__init__(...) -> None` when there is any argument aside from the first `self`. This patch follows the parenthetical recommendation from PEP 484 that `-> None` be given anyways. References: * https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-disallow-untyped-defs * https://mypy.readthedocs.io/en/stable/error_code_list2.html#check-that-every-function-has-an-annotation-no-untyped-def * https://peps.python.org/pep-0484/#the-meaning-of-annotations Signed-off-by: Alex Nelson <[email protected]>
… type Signed-off-by: Alex Nelson <[email protected]>
Defaulting to the string `"none"` has a functional consequence in downstream pySHACL operations, as encoded at the time of this writing (pySHACL version 0.23.0). `inference` in the `pyshacl.validate(...)` arguments is propagated down two code paths that both impact the validation operation, but that use different default values. The `--metashacl` (SHACL-SHACL validation graph for reviewing shape syntax)- aligned code path defaults to `rdfs` inference, and the `Validator` class defaults to the string `"none"`. Signed-off-by: Alex Nelson <[email protected]>
…do_concepts case_validate: Expose CDO IRI typo-checker as function
Move doctests checking to own target in preorder traversal
…default case_validate: Default inference flag to None rather than "none"
Signed-off-by: Alex Nelson <[email protected]>
…n "none" This is a continuation of PR 123. References: * #123 Signed-off-by: Alex Nelson <[email protected]>
…idate This patch separates implementation points between functionality distinct to `case_utils.validate` and `pyshacl.validate`. The `allow_warnings` and `inference` parameters provide CASE-specific documentation as an augmentation to `pyshacl.validate`'s documentation, but otherwise other documentation on `pyshacl.validate`'s keyword arguments is delegated to their upstream function. This patch removes some hardcoded parameter values in `pyshacl.validate`, letting the `case_validate` CLI or caller provide any runtime-requested values. Also, without functional impact, this patch sorts keyword parameters alphabetically. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Library Usage
Signed-off-by: Alex Nelson <[email protected]>
Adjust documentation of exposed local_uuid API
Update NIST inlined license text
This is part of addressing what originally inspired pySHACL Issue 170. This patch modifies the behavior of `case_validate`, that reviews OWL syntax and OWL-SHACL interactions. With this patch, that functionality is now **opt-in** at call time. Further work on separating the OWL review shapes from UCO into a general CDO repository (originally started for CDOTSC-34) is currently believed to not have an impact on the user interface element where the user opts in to the more extensive review. References: * [CDOTSC-34] CDO should provide shapes for external ontologies and other RDF models, including OWL * RDFLib/pySHACL#170 Signed-off-by: Alex Nelson <[email protected]>
Reduce redundant case_validate analysis
Signed-off-by: Alex Nelson <[email protected]>
kchason
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordination