Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on six #273

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Remove dependency on six #273

merged 3 commits into from
Sep 2, 2024

Conversation

tammojan
Copy link
Contributor

Casacore (and the rest of the world) has effectively dropped support for python 2, I think we can drop this support here as well.

@pep8speaks
Copy link

pep8speaks commented Aug 28, 2024

Hello @tammojan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 486:80: E501 line too long (82 > 79 characters)
Line 487:80: E501 line too long (83 > 79 characters)
Line 497:80: E501 line too long (81 > 79 characters)
Line 555:31: E127 continuation line over-indented for visual indent
Line 557:35: E127 continuation line over-indented for visual indent
Line 561:12: E228 missing whitespace around modulo operator
Line 565:15: E203 whitespace before ':'

Comment last updated at 2024-09-02 09:59:20 UTC

@a-detiste
Copy link
Contributor

a-detiste commented Sep 1, 2024

The from __future__ import print_function I introduced in previous PR #261 can now go too.

Copy link
Collaborator

@gmloose gmloose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping support for Python 2 would also mean removing all from __future__ import print_function lines. The new print function has been there since Python 3.0.

@tammojan tammojan merged commit f2f1c20 into master Sep 2, 2024
7 checks passed
@tammojan tammojan deleted the remove_six branch September 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants