-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cibuildwheel #259
Merged
Merged
Use cibuildwheel #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First working version. Probably needs some brushing up :)
Removed existing `linux.yml` and `osx.yml` to avoid interference with new `build_release.yml`. At a later stage, we may want to revive some parts of the old workflows.
Casacore base images do not yet exist. So, I cannot yet test the new workflow. Best to revert for now. This reverts commit 3045b47.
In the grand old days, Homebrew installed to `/usr/local` and all was well. Now, however, while Intel Homebrew still does this, Apple Silicon / M1 / M2 Homebrew has gone and picked a new prefix: `/opt/homebrew`. A good explanation of the rationale is at https://earthly.dev/blog/homebrew-on-m1/. Basically, Homebrew had to admit that Fink and MacPorts were right. :-P The solution is to call `brew --prefix` and add those libraries explicitly to the search list. Keep going if brew is not installed. This addresses #252.
The CI/CD pipeline still uses some old kern-6 docker images based on Python 3.6. The code no longer works with Python 3.6, and we have dropped support for it. Disabled the offending steps.
Replace `ADD` with `COPY` to see if error disappears.
This reverts commit cb15b62.
tammojan
approved these changes
Feb 16, 2024
gmloose
added a commit
that referenced
this pull request
Feb 16, 2024
This PR adds support for building `python-casacore` using [cibuildwheel](https://cibuildwheel.readthedocs.io/en/stable/), and a GitHub workflow that builds and uploads these wheels to [PyPI](https://pypi.org/project/python-casacore/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #254.