Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a badge containing DOI for peer-reviewed lessons #97

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Add a badge containing DOI for peer-reviewed lessons #97

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32d9928
add badge containing DOI for peer-reviewed lessons
tobyhodges Oct 30, 2023
c155b5e
make all lifecycle icons badges
zkamvar Nov 10, 2023
9628b61
add 1em right margin to header logo for badges
zkamvar Nov 10, 2023
1d16011
regenerated css/js
actions-user Nov 10, 2023
1f51953
Merge branch 'main' into add-doi-banner
zkamvar Nov 10, 2023
3b6deb9
regenerated css/js
actions-user Nov 10, 2023
eccd2b1
bump version; add NEWS
zkamvar Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions inst/pkgdown/templates/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@
<span class="visually-hidden">This lesson is in the beta phase, which means that it is ready for teaching by instructors outside of the original author team.</span>
</abbr>
{{/beta}}
{{#stable}}
{{#doi}}
<abbr class="badge badge-light" title="This lesson has passed peer review">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to leave the badge as a white box that blends in with the background? I know that we went through the primary colours in Brand identity for the icons, but we may be able to come up with something that looks pleasing enough.

<i aria-hidden="true" class="icon" data-feather="user-check" style="color: #383838; border-radius: 5px"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this icon element can be embedded within the <a> element

<a href="{{doi}}" class="external-link alert-link" style="color: #383838;">DOI: {{doi}}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the href attribute should be https://doi.org/{{doi}} because usually DOIs are displayed without the HTTPS part. This would also make it easier for us to change the DOI URL if the doi.org domain decides to change.

</abbr>
{{/doi}}
{{/stable}}
{{/life_cycle}}{{/yaml}}
</div>
</div>
Expand Down
Loading