Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section #61

Open
wants to merge 1 commit into
base: legacy/main
Choose a base branch
from
Open

Conversation

jokergoo
Copy link

@jokergoo jokergoo commented Feb 5, 2023

In this PR, I added a new section "The install.packages() function" to introduce how to install Bioconductor packages with the command install.packages(). Feel free to accept it or reject it (if you think it makes the teaching complicated).

Instructions

Thanks for contributing! ❤️

If this contribution is for instructor training, please email the link to this contribution to
[email protected] so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at [email protected].

You may delete these instructions from your comment.

- The Carpentries

@kevinrue
Copy link
Collaborator

kevinrue commented Apr 2, 2024

Sorry for leaving this repository unattended for so long.

My first instinct was that this may be beyond the scope of the episode. However, I see that I've already included a section "going further" that lists other R functions to install packages, so I would contradict myself there.

Thinking about it more, I think your addition is an important message to users. Given that it relates to installing packages, I would move it from the end of the page where you seem to have place it, to the same level as my "going further block". In fact, I think that the two could be combined and make the whole thing cleaner.

I think this requires a bit attention and care to polish, which I'm sorry to say I don't have right now.

One more note I would add is that I'm not sure I'd highlight setRepositories() if it relies on a pop-up window. I personally prefer to call options(repos = BiocManager::repositories() to achieve the same effect entirely programmatically. It also saves the screenshot, as the code displays much more nicely in the episode format. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants