Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifiarr footer and icon attributes set #977

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 15, 2023

Description:

Related issue (if applicable): #949 and #953

Added footer and image details as part of the notifiarr payload

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@949-notifiarr-extra-requests

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "notifiarr://credentials"

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
apprise/plugins/NotifyNotifiarr.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@caronc caronc merged commit bd28bf9 into master Oct 15, 2023
12 checks passed
@caronc caronc deleted the 949-notifiarr-extra-requests branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants