-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix login URL updated to accomodate newer API #970
Conversation
@corentincam, I would love your feedback on this to see if it helps/works for you taking your advice. I'm a bit surprised because i added attachment support recently and I did not have authentication issues at the time using the Matrix build i had. Is this a very recent change? |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Thanks for this quick fix! Authentication and Deauthentication seem fixed, but the message sending was still broken for me... I could make it work with a few changes though:
Those changes probably need some adjustments to fit your coding guidelines and allow retrocompatibility, but I can confirm they work with my conduit server v0.6.0 |
601b524
to
c9ef17f
Compare
I pushed your changes, but it seems that the If you test the following, i can't seem to figure out where i'm going wrong with the payload, maybe you spot it? # you can use the `test/var/*` contents available in this package
apprise -b "message" --attach test/var/apprise-test.jpeg \
"matrix://credentials" The good news however is your code works (you can post to the Matrix Server); good work on your part here! I'd like to figure out the attachments though before closing this off for good. |
In this latest update . |
Sorry I couldn't reply earlier, indeed the attachment doesn't seem to work out-of-the-box. I made some changes and I feel it could be doable. Not sure when I'll be able to actually work on it but I might open a PR if I figure out how to do this. Thanks for the great work anyways! |
Description:
Related issue (if applicable): #968
Basing fix on related issue and Matrix API Login Docs
Checklist
flake8
)Testing
Anyone can help test this source code as follows: