Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case to support question related to Apprise and Synology #920

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 7, 2023

Description:

Related issue (if applicable): #908

Just added a test case to help work out a question posted by a user of Apprise trying to use the form:// to submit to their Synology server.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@908-synology-format-testcase

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "forms://[hostname]:[port]/webapi/entry.cgi?-api=SYNO.Chat.External&-method=incoming&-version=2&-token=xxx"

@caronc caronc force-pushed the 908-synology-format-testcase branch from 9e4497f to 0369c0a Compare August 7, 2023 18:01
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
apprise/plugins/NotifyJSON.py 100.00%

📢 Thoughts on this report? Let us know!.

@caronc caronc merged commit f799066 into master Sep 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants