-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require ActiveSupport #298
base: master
Are you sure you want to change the base?
Conversation
665993d
to
8727e4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change with a gem that requires carmen, and it works flawlessly. My only question is whether require 'active_support/core_ext/string'
is still needed. It does not appear necessary at all.
This change, in and of itself, appears to fix the issue in question, though. I approve it. If anyone is unsure about the need for the other require
line, and wants to investigate further, I see no reason to hold up this fix in the mean time.
@apotheon it looks like the other
|
Thanks. I stand corrected regarding the other |
@benhutton - How do you feel about maintaining a fork and pulling in code from pull requests already submitted as needed? Perhaps name it "SanDiego" and publish it as a gem. That's assuming you know the codebase well enough and have time to be a maintainer. |
@apotheon I definitely don't know this codebase at all! Sorry |
This fixes #297.