Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ... in rest_framework.txt to make life easy #1651

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

vainl
Copy link
Contributor

@vainl vainl commented Mar 26, 2024

Someone silly like me, who just copies and posts the code snippet with the ..., will get an exception AttributeError: 'ellipsis' object has no attribute 'rsplit'. So let's just remove it and make life easy.

Someone silly like me, who just copies and posts the code snippet with the ..., will get an exception `AttributeError: 'ellipsis' object has no attribute 'rsplit'`. So let's just remove it and make life easy.
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's meant to imply there's more there. I'd be happy if you replaced it with a commment # …

@jeremystretch
Copy link

IMO it's very important to retain some indicator that the example does not represent the complete configuration, to avoid confusion.

So let's add a comment and keep the ellipsis there.
@vainl
Copy link
Contributor Author

vainl commented Mar 26, 2024

It's meant to imply there's more there. I'd be happy if you replaced it with a commment # …

Done. I just a comment.

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@carltongibson carltongibson merged commit 89c65d4 into carltongibson:main Mar 26, 2024
9 checks passed
last-partizan pushed a commit to last-partizan/django-filter that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants