Add address query parameter to ws server

CHANGELOG.md

@@ -48,7 +48,7 @@ changes.
 
 - Update mithril to `2442.0`
 
-
+- Filter `TxValid` and `TxInvalid` server outputs by address.
 
 ## [0.19.0] - 2024-09-13
 

docs/docs/api-behavior.md

@@ -20,6 +20,7 @@ There are some options for API clients to control the server outputs. Server out
 
 + `history=no` -> Prevents historical outputs display. All server outputs are recorded and when a client re-connects these outputs are replayed unless `history=no` query param is used.
 + `snapshot-utxo=no` -> In case of a `SnapshotConfirmed` message the `utxo` field in the inner `Snapshot` will be omitted.
++ `address=$address` -> In case of a `TxValid` or a `TxInvalid` message, it will be filtered if its `transaction` address does not contains a reference to the provided.
 
 ## Replay of past server outputs
 

hydra-cluster/hydra-cluster.cabal

@@ -151,6 +151,7 @@ test-suite tests
     Test.GeneratorSpec
     Test.Hydra.Cluster.CardanoCliSpec
     Test.Hydra.Cluster.FaucetSpec
+    Test.Hydra.Cluster.HydraClientSpec
     Test.Hydra.Cluster.MithrilSpec
     Test.Hydra.Cluster.Utils
     Test.HydraExplorerSpec

hydra-cluster/src/HydraNode.hs

@@ -88,6 +88,14 @@ output tag pairs = object $ ("tag" .= tag) : pairs
 waitFor :: HasCallStack => Tracer IO HydraNodeLog -> NominalDiffTime -> [HydraClient] -> Aeson.Value -> IO ()
 waitFor tracer delay nodes v = waitForAll tracer delay nodes [v]
 
+-- | Wait up to some time and succeed if no API server output matches the given predicate.
+waitNoMatch :: HasCallStack => NominalDiffTime -> HydraClient -> (Aeson.Value -> Maybe a) -> IO ()
+waitNoMatch delay client match = do
+  result <- try (void $ waitMatch delay client match) :: IO (Either SomeException ())
+  case result of
+    Left _ -> pure () -- Success: waitMatch failed to find a match
+    Right _ -> failure "waitNoMatch: A match was found when none was expected"
+
 -- | Wait up to some time for an API server output to match the given predicate.
 waitMatch :: HasCallStack => NominalDiffTime -> HydraClient -> (Aeson.Value -> Maybe a) -> IO a
 waitMatch delay client@HydraClient{tracer, hydraNodeId} match = do
@@ -406,7 +414,7 @@ withConnectionToNode tracer hydraNodeId =
   port = fromInteger $ 4_000 + toInteger hydraNodeId
 
 withConnectionToNodeHost :: forall a. Tracer IO HydraNodeLog -> Int -> Host -> Maybe String -> (HydraClient -> IO a) -> IO a
-withConnectionToNodeHost tracer hydraNodeId apiHost@Host{hostname, port} queryParams action = do
+withConnectionToNodeHost tracer hydraNodeId apiHost@Host{hostname, port} mQueryParams action = do
   connectedOnce <- newIORef False
   tryConnect connectedOnce (200 :: Int)
  where
@@ -424,9 +432,9 @@ withConnectionToNodeHost tracer hydraNodeId apiHost@Host{hostname, port} queryPa
                     , Handler $ retryOrThrow (Proxy @HandshakeException)
                     ]
 
-  historyMode = fromMaybe "/" queryParams
+  queryParams = fromMaybe "/" mQueryParams
 
-  doConnect connectedOnce = runClient (T.unpack hostname) (fromInteger . toInteger $ port) historyMode $
+  doConnect connectedOnce = runClient (T.unpack hostname) (fromInteger . toInteger $ port) queryParams $
     \connection -> do
       atomicWriteIORef connectedOnce True
       traceWith tracer (NodeStarted hydraNodeId)

hydra-cluster/test/Test/Hydra/Cluster/HydraClientSpec.hs

@@ -0,0 +1,294 @@
+{-# LANGUAGE DuplicateRecordFields #-}
+{-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-}
+
+module Test.Hydra.Cluster.HydraClientSpec where
+
+import Hydra.Prelude
+import Test.Hydra.Prelude
+
+import Cardano.Api.UTxO qualified as UTxO
+import CardanoClient (
+  RunningNode (..),
+  submitTx,
+ )
+import CardanoNode (
+  withCardanoNodeDevnet,
+ )
+import Control.Lens ((^?))
+import Data.Aeson ((.=))
+import Data.Aeson.Lens (key)
+import Data.Aeson.Types (parseMaybe)
+import Data.Set qualified as Set
+import Data.Text qualified as Text
+import Hydra.Cardano.Api hiding (Value, cardanoEra, queryGenesisParameters)
+import Hydra.Chain.Direct.State ()
+import Hydra.Cluster.Faucet (
+  publishHydraScriptsAs,
+  seedFromFaucet,
+  seedFromFaucet_,
+ )
+import Hydra.Cluster.Fixture (
+  Actor (Faucet),
+  alice,
+  aliceSk,
+  bob,
+  bobSk,
+  carol,
+  carolSk,
+ )
+import Hydra.Cluster.Scenarios (
+  EndToEndLog (..),
+  headIsInitializingWith,
+ )
+import Hydra.Ledger.Cardano (mkSimpleTx, mkTransferTx)
+import Hydra.Logging (Tracer, showLogsOnFailure)
+import Hydra.Tx (HeadId, IsTx (..))
+import Hydra.Tx.ContestationPeriod (ContestationPeriod (UnsafeContestationPeriod))
+import HydraNode (HydraClient (..), HydraNodeLog, input, output, requestCommitTx, send, waitFor, waitForAllMatch, waitForNodesConnected, waitMatch, waitNoMatch, withConnectionToNodeHost, withHydraCluster)
+import Test.Hydra.Tx.Fixture (testNetworkId)
+import Test.Hydra.Tx.Gen (genKeyPair)
+import Test.QuickCheck (generate)
+import Prelude qualified
+
+spec :: Spec
+spec = around (showLogsOnFailure "HydraClientSpec") $ do
+  describe "HydraClient on Cardano devnet" $ do
+    describe "hydra-client" $ do
+      it "should filter TxValid by provided address" $ \tracer -> do
+        failAfter 60 $
+          withTempDir "hydra-client" $ \tmpDir ->
+            filterTxValidByAddressScenario tracer tmpDir
+      it "should filter out TxValid when given a random address" $ \tracer -> do
+        failAfter 60 $
+          withTempDir "hydra-client" $ \tmpDir ->
+            filterTxValidByRandomAddressScenario tracer tmpDir
+      it "should filter out TxValid when given a wrong address" $ \tracer -> do
+        failAfter 60 $
+          withTempDir "hydra-client" $ \tmpDir ->
+            filterTxValidByWrongAddressScenario tracer tmpDir
+
+filterTxValidByAddressScenario :: Tracer IO EndToEndLog -> FilePath -> IO ()
+filterTxValidByAddressScenario tracer tmpDir = do
+  scenarioSetup tracer tmpDir $ \node nodes hydraTracer -> do
+    (initialTxId, headId, (aliceExternalVk, _), (bobExternalVk, bobExternalSk)) <-
+      prepareScenario node nodes tracer
+    let [n1, n2, _] = toList nodes
+
+    -- 1/ query alice address from alice node -> Does see the tx
+    runScenario hydraTracer n1 (textAddrOf aliceExternalVk) $ \con -> do
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+    -- 2/ query bob address from bob node -> Does see the tx
+    runScenario hydraTracer n2 (textAddrOf bobExternalVk) $ \con -> do
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+    -- 3/ query bob address from alice node -> Does see the tx
+    runScenario hydraTracer n1 (textAddrOf bobExternalVk) $ \con -> do
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+    -- 4/ query alice address from alice node -> Does not see the bob-self tx
+    newTxId <- runScenario hydraTracer n1 (textAddrOf aliceExternalVk) $ \con -> do
+      send n1 $ input "GetUTxO" []
+      utxo <- waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "GetUTxOResponse"
+        headId' :: HeadId <- v ^? key "headId" >>= parseMaybe parseJSON
+        guard $ headId == headId'
+        v ^? key "utxo" >>= parseMaybe parseJSON
+
+      newTx <- sendTransferTx nodes utxo bobExternalSk bobExternalVk
+      waitFor hydraTracer 10 (toList nodes) $
+        output "TxValid" ["transactionId" .= txId newTx, "headId" .= headId, "transaction" .= newTx]
+
+      waitNoMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == txId newTx
+
+      pure (txId newTx)
+
+    -- 5/ query bob address from alice node -> Does see the both tx from history.
+    runScenario hydraTracer n1 (textAddrOf bobExternalVk) $ \con -> do
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == newTxId
+
+    -- 6/ query bob address from alice node -> Does not see new bob-self tx
+    runScenario hydraTracer n1 (textAddrOf bobExternalVk) $ \con -> do
+      send n1 $ input "GetUTxO" []
+      utxo <- waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "GetUTxOResponse"
+        headId' :: HeadId <- v ^? key "headId" >>= parseMaybe parseJSON
+        guard $ headId == headId'
+        v ^? key "utxo" >>= parseMaybe parseJSON
+
+      newTx <- sendTransferTx nodes utxo bobExternalSk bobExternalVk
+
+      waitMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == txId newTx
+
+filterTxValidByRandomAddressScenario :: Tracer IO EndToEndLog -> FilePath -> IO ()
+filterTxValidByRandomAddressScenario tracer tmpDir = do
+  scenarioSetup tracer tmpDir $ \node nodes hydraTracer -> do
+    (initialTxId, _, _, _) <- prepareScenario node nodes tracer
+    let [n1, _, _] = toList nodes
+
+    (randomVk, _) <- generate genKeyPair
+    runScenario hydraTracer n1 (textAddrOf randomVk) $ \con -> do
+      waitNoMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+filterTxValidByWrongAddressScenario :: Tracer IO EndToEndLog -> FilePath -> IO ()
+filterTxValidByWrongAddressScenario tracer tmpDir = do
+  scenarioSetup tracer tmpDir $ \node nodes hydraTracer -> do
+    (initialTxId, _, _, _) <- prepareScenario node nodes tracer
+    let [_, _, n3] = toList nodes
+
+    runScenario hydraTracer n3 "invalid" $ \con -> do
+      waitNoMatch 3 con $ \v -> do
+        guard $ v ^? key "tag" == Just "TxValid"
+        tx :: Tx <- v ^? key "transaction" >>= parseMaybe parseJSON
+        guard $ txId tx == initialTxId
+
+-- * Helpers
+unwrapAddress :: AddressInEra -> Text
+unwrapAddress = \case
+  ShelleyAddressInEra addr -> serialiseToBech32 addr
+  ByronAddressInEra{} -> error "Byron."
+
+textAddrOf :: VerificationKey PaymentKey -> Text
+textAddrOf vk = unwrapAddress (mkVkAddress @Era testNetworkId vk)
+
+queryAddress :: Text -> Text
+queryAddress addr = "/?history=yes&address=" <> addr
+
+runScenario ::
+  Tracer IO HydraNodeLog ->
+  HydraClient ->
+  Text ->
+  (HydraClient -> IO a) ->
+  IO a
+runScenario hydraTracer hnode addr action = do
+  withConnectionToNodeHost
+    hydraTracer
+    (HydraNode.hydraNodeId hnode)
+    (HydraNode.apiHost hnode)
+    (Just $ Text.unpack (queryAddress addr))
+    action
+
+scenarioSetup ::
+  Tracer IO EndToEndLog ->
+  FilePath ->
+  (RunningNode -> NonEmpty HydraClient -> Tracer IO HydraNodeLog -> IO a) ->
+  IO a
+scenarioSetup tracer tmpDir action = do
+  withCardanoNodeDevnet (contramap FromCardanoNode tracer) tmpDir $ \node@RunningNode{nodeSocket} -> do
+    aliceKeys@(aliceCardanoVk, _) <- generate genKeyPair
+    bobKeys@(bobCardanoVk, _) <- generate genKeyPair
+    carolKeys@(carolCardanoVk, _) <- generate genKeyPair
+
+    let cardanoKeys = [aliceKeys, bobKeys, carolKeys]
+        hydraKeys = [aliceSk, bobSk, carolSk]
+
+    let firstNodeId = 1
+    hydraScriptsTxId <- publishHydraScriptsAs node Faucet
+    let contestationPeriod = UnsafeContestationPeriod 2
+    let hydraTracer = contramap FromHydraNode tracer
+    withHydraCluster hydraTracer tmpDir nodeSocket firstNodeId cardanoKeys hydraKeys hydraScriptsTxId contestationPeriod $ \nodes -> do
+      let [n1, n2, n3] = toList nodes
+      waitForNodesConnected hydraTracer 20 $ n1 :| [n2, n3]
+
+      -- Funds to be used as fuel by Hydra protocol transactions
+      seedFromFaucet_ node aliceCardanoVk 100_000_000 (contramap FromFaucet tracer)
+      seedFromFaucet_ node bobCardanoVk 100_000_000 (contramap FromFaucet tracer)
+      seedFromFaucet_ node carolCardanoVk 100_000_000 (contramap FromFaucet tracer)
+
+      action node nodes hydraTracer
+
+prepareScenario ::
+  RunningNode ->
+  NonEmpty HydraClient ->
+  Tracer IO EndToEndLog ->
+  IO (TxId, HeadId, (VerificationKey PaymentKey, SigningKey PaymentKey), (VerificationKey PaymentKey, SigningKey PaymentKey))
+prepareScenario node nodes tracer = do
+  let [n1, n2, n3] = toList nodes
+  let hydraTracer = contramap FromHydraNode tracer
+
+  send n1 $ input "Init" []
+  headId <-
+    waitForAllMatch 10 [n1, n2, n3] $
+      headIsInitializingWith (Set.fromList [alice, bob, carol])
+
+  -- Get some UTXOs to commit to a head
+  aliceKeys@(aliceExternalVk, aliceExternalSk) <- generate genKeyPair
+  committedUTxOByAlice <- seedFromFaucet node aliceExternalVk aliceCommittedToHead (contramap FromFaucet tracer)
+  requestCommitTx n1 committedUTxOByAlice <&> signTx aliceExternalSk >>= submitTx node
+
+  bobKeys@(bobExternalVk, bobExternalSk) <- generate genKeyPair
+  committedUTxOByBob <- seedFromFaucet node bobExternalVk bobCommittedToHead (contramap FromFaucet tracer)
+  requestCommitTx n2 committedUTxOByBob <&> signTx bobExternalSk >>= submitTx node
+
+  requestCommitTx n3 mempty >>= submitTx node
+
+  let u0 = committedUTxOByAlice <> committedUTxOByBob
+
+  waitFor hydraTracer 10 [n1, n2, n3] $ output "HeadIsOpen" ["utxo" .= u0, "headId" .= headId]
+
+  -- Create an arbitrary transaction using some input to have history.
+  tx <- sendTx nodes committedUTxOByAlice aliceExternalSk bobExternalVk paymentFromAliceToBob
+  waitFor hydraTracer 10 (toList nodes) $
+    output "TxValid" ["transactionId" .= txId tx, "headId" .= headId, "transaction" .= tx]
+  pure (txId tx, headId, aliceKeys, bobKeys)
+
+-- NOTE(AB): this is partial and will fail if we are not able to generate a payment
+sendTx :: NonEmpty HydraClient -> UTxO' (TxOut CtxUTxO) -> SigningKey PaymentKey -> VerificationKey PaymentKey -> Lovelace -> IO Tx
+sendTx nodes senderUTxO sender receiver amount = do
+  let utxo = Prelude.head $ UTxO.pairs senderUTxO
+  let Right tx =
+        mkSimpleTx
+          utxo
+          (inHeadAddress receiver, lovelaceToValue amount)
+          sender
+  send (head nodes) $ input "NewTx" ["transaction" .= tx]
+  pure tx
+
+sendTransferTx :: NonEmpty HydraClient -> UTxO -> SigningKey PaymentKey -> VerificationKey PaymentKey -> IO Tx
+sendTransferTx nodes utxo sender receiver = do
+  tx <- mkTransferTx testNetworkId utxo sender receiver
+  send (head nodes) $ input "NewTx" ["transaction" .= tx]
+  pure tx
+
+-- * Fixtures
+
+aliceCommittedToHead :: Num a => a
+aliceCommittedToHead = 20_000_000
+
+bobCommittedToHead :: Num a => a
+bobCommittedToHead = 5_000_000
+
+paymentFromAliceToBob :: Num a => a
+paymentFromAliceToBob = 1_000_000
+
+inHeadAddress :: VerificationKey PaymentKey -> AddressInEra
+inHeadAddress =
+  mkVkAddress network
+ where
+  network = Testnet (NetworkMagic 14)