Merge pull request #86 from cardano-foundation/fix/tx_item_update_fail

fix: transaction items update
cardano-foundation · Nov 14, 2024 · c28cc28 · c28cc28
2 parents b0ac608 + 00fa66b
commit c28cc28
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.../cardanofoundation/lob/app/accounting_reporting_core/domain/entity/TransactionEntity.java b/.../cardanofoundation/lob/app/accounting_reporting_core/domain/entity/TransactionEntity.java
@@ -110,7 +110,7 @@ public class TransactionEntity extends CommonEntity implements Persistable<Strin
     @Setter
     private Boolean ledgerDispatchApproved = false;
 
-    @OneToMany(mappedBy = "transaction", orphanRemoval = true, fetch = EAGER)
+    @OneToMany(mappedBy = "transaction", orphanRemoval = true, fetch = EAGER, cascade = CascadeType.ALL)
     private Set<TransactionItemEntity> items = new LinkedHashSet<>();
 
     @OneToOne(fetch = FetchType.LAZY)

diff --git a/...n/lob/app/accounting_reporting_core/service/internal/DbSynchronisationUseCaseService.java b/...n/lob/app/accounting_reporting_core/service/internal/DbSynchronisationUseCaseService.java
@@ -100,7 +100,8 @@ private void processTransactionsForTheFirstTime(String batchId,
                     val attached = txM.orElseThrow();
 
                     transactionConverter.copyFields(attached, incomingTx);
-
+                    attached.getAllItems().clear();
+                    attached.getAllItems().addAll(incomingTx.getAllItems());
                     toProcessTransactions.add(attached);
                 } else {
                     toProcessTransactions.add(incomingTx);