Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that an empty wallet can't join a stake pool (no_utxos_available) #4376

Merged
merged 7 commits into from
Dec 27, 2023
Merged

Test that an empty wallet can't join a stake pool (no_utxos_available) #4376

merged 7 commits into from
Dec 27, 2023

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Dec 25, 2023 •
edited
Loading

  • Opportunistically improved some code and docs (chore: commits)
  • Replicated E2E test which verifies that an empty wallet can't join a stake pool (no_utxos_available) at the level of local cluster integration.
  • Removed original E2E integration test that was running against the preprod in favour of the test created for the local cluster integration.
  • Fixed the original problem by 1) requiring a non-empty UTxO selection for balancing; 2) Failing explicitly with the no_utxos_available before trying to balance tx;

Issue Number

ADP-3250

@Unisay Unisay self-assigned this Dec 25, 2023
@Unisay Unisay force-pushed the yura/ADP-3250/no_utxos_available branch 2 times, most recently from 7f2adab to ad9dead Compare December 26, 2023 12:02
paolino
paolino approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given that we fix all new failures ..

@Unisay Unisay force-pushed the yura/ADP-3250/no_utxos_available branch from ad9dead to e99224d Compare December 27, 2023 08:23
@Unisay Unisay marked this pull request as ready for review December 27, 2023 08:49
@Unisay
Fix integration tests:
5f848e9 
STAKE_POOLS_JOIN_EMPTY, TRANS_NEW_BALANCE_02a, TRANS_NEW_CREATE_04d
@Unisay Unisay force-pushed the yura/ADP-3250/no_utxos_available branch from 368db74 to 5f848e9 Compare December 27, 2023 10:22
@Unisay Unisay requested a review from paolino December 27, 2023 10:44
@Unisay Unisay added this pull request to the merge queue Dec 27, 2023
paolino
paolino approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into master with commit 2253b4c Dec 27, 2023
4 checks passed
@Unisay Unisay deleted the yura/ADP-3250/no_utxos_available branch December 27, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@Unisay Unisay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unisay @paolino