Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3224] Use skip instead of pending in join/leave SP flaky E2E tests #4354

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[ADP-3224] Use skip instead of pending in join/leave SP flaky E2E tests #4354

merged 1 commit into from
Dec 18, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Dec 18, 2023 •
edited
Loading

  • Use skip instead of pending when tests are flaky (E2E join/quit). Pending will fail if the test succeed.

ADP-3224

@paolino paolino requested a review from Unisay December 18, 2023 09:14
@paolino paolino self-assigned this Dec 18, 2023
@paolino paolino force-pushed the paolino/ADP-3224/switch-from-pending-to-skip-in-stakepool-join-leave-E2E-tests branch from b6d91a5 to 23a748a Compare December 18, 2023 09:28
@paolino paolino added this pull request to the merge queue Dec 18, 2023
Merged via the queue into master with commit 4f86f5d Dec 18, 2023
4 of 5 checks passed
@paolino paolino deleted the paolino/ADP-3224/switch-from-pending-to-skip-in-stakepool-join-leave-E2E-tests branch December 18, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unisay Unisay Unisay approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @Unisay