Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3224] Fix caching problems in GH workflows, add slack reporting #4272

Merged
merged 13 commits into from
Nov 30, 2023
Merged

[ADP-3224] Fix caching problems in GH workflows, add slack reporting #4272

merged 13 commits into from
Nov 30, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 28, 2023 •
edited
Loading

  • Add blockchain snapshot download on cache-hit fail
  • Remove support for other networks than preprod
  • Add slack reporting to release-relevant workflows

The result is that tests are running correctly but we still have failures

@paolino paolino self-assigned this Nov 28, 2023
@paolino paolino force-pushed the paolino/ADP-3224/fix-e2e branch 29 times, most recently from 4f18717 to 6f1d725 Compare November 29, 2023 16:38
paweljakubas
paweljakubas approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! You might consider extracting slack reporting and preprod setup and snapshot fetching in a separate file and reuse it in a number of places

@paolino paolino added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@paolino paolino added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@paolino paolino added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@paolino paolino changed the base branch from master to paolino/let-hls-step-soft-fail November 30, 2023 14:46
@paolino paolino merged commit b5038c8 into paolino/let-hls-step-soft-fail Nov 30, 2023
3 of 4 checks passed
@paolino paolino deleted the paolino/ADP-3224/fix-e2e branch November 30, 2023 14:46
@paolino paolino restored the paolino/ADP-3224/fix-e2e branch November 30, 2023 14:56
@paolino paolino deleted the paolino/ADP-3224/fix-e2e branch November 30, 2023 15:00
@paolino paolino restored the paolino/ADP-3224/fix-e2e branch November 30, 2023 15:00
@paolino paolino deleted the paolino/ADP-3224/fix-e2e branch November 30, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @paweljakubas