Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STONX token logo update #4020

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Conversation

SimoDod
Copy link
Contributor

@SimoDod SimoDod commented Feb 6, 2024

Pull Request Template

Description

Changing the base64 logo as the last one has a wrong dimensions and looks broken.

Type of change

  • Metadata related change
  • Other

Checklist:

  • For metadata related changes, this PR code passes the GitHub Actions metadata validation

Metadata PRs

Please note it may take up to 4 hours for merged changes to take effect on the metadata server.

@SimoDod SimoDod changed the title STONX TOKEN image update STONX token logo update Feb 6, 2024
@Godspeed-exe
Copy link
Contributor

Hello @SimoDod

The validation is failing because you didn't increment the sequenceNumber value. This needs to be incremented when doing updates. I would point you to this guide: https://github.com/cardano-foundation/cardano-token-registry/wiki/How-do-I-update-my-entry-in-the-registry%3F

Let me know if you have any questions!

@Godspeed-exe
Copy link
Contributor

Hello @SimoDod

Did you also re-sign the updated value? The attestation is failing which makes me believe that the signature wasn't update. Looking at the changes on the file I can also see that the signature isn't changed, while the value is changed, so this needs to be updated.

@SimoDod
Copy link
Contributor Author

SimoDod commented Feb 6, 2024

Hello @Godspeed-exe

I've generated the token through a website, streamlining the process significantly.
As I delved deeper into the details, I cloned the repository and began building the token-metadata-registry.
Initially, I thought merely adjusting the sequence would suffice, but I've come to realize that signing the data is also necessary.

I will push a new commit once I build the token-metadata-registry with nix and sign the token metadata correctly.

btw if there is an easier way, I am open for suggestions :)

@SimoDod SimoDod closed this Feb 6, 2024
@Godspeed-exe
Copy link
Contributor

@SimoDod

There are simpler ways indeed:

@SimoDod SimoDod reopened this Feb 6, 2024
@Godspeed-exe
Copy link
Contributor

Godspeed-exe commented Feb 6, 2024

@SimoDod still seems to be failing on the signature of the logo.

update now it’s okay!

@Godspeed-exe Godspeed-exe merged commit 6377337 into cardano-foundation:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants