Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWT #3623

Merged
merged 1 commit into from
Nov 7, 2023
Merged

BWT #3623

merged 1 commit into from
Nov 7, 2023

Conversation

adaBiomeBoss
Copy link
Contributor

@adaBiomeBoss adaBiomeBoss commented Nov 4, 2023

BiomeWorld

charity driven memecoin

Please include a short summary of the changes in this PR.

none

  • Metadata related change
  • Other

Checklist:

  • For metadata related changes, this PR code passes the GitHub Actions metadata validation

Metadata PRs

Please note it may take up to 4 hours for merged changes to take effect on the metadata server.

@adaBiomeBoss
Copy link
Contributor Author

dear all, this is my very first time doing this and i am eager to learn, if anyone has tips and tricks for me or something is should change feel free to advice it to me.
thanks in advance

@Kartiiyer12
Copy link
Contributor

Hi @adaBiomeBoss ,
The file name must match the encoded "subject" key of the entry, all lowercase. So the name would be cc7133ad03527cd6b80fcc1aef752f34eda627b085236a5c9a7bad0b425754.json for the file name.

@adaBiomeBoss adaBiomeBoss changed the title Create BWT BWT Nov 6, 2023
@adaBiomeBoss
Copy link
Contributor Author

Hi @adaBiomeBoss , The file name must match the encoded "subject" key of the entry, all lowercase. So the name would be cc7133ad03527cd6b80fcc1aef752f34eda627b085236a5c9a7bad0b425754.json for the file name.

dear @Kartiiyer12 i followed your advice and ended up with the comment "pull request successfully merged and closed" but according to online sources this does not mean its registered, but the checks are complete, i only need an approving review for it to be merged if i understand correctly.
thank you for your contributions so far, but i have one more question; how do i receive an aproving review and who will do this?

thanks in andvance and for your previous contributions. and i hope i could work further with your futur advice.

kind regards, adabiomeboss

here you can find a screenshot of what i have now at the moment.
Schermafbeelding 2023-11-06 204128

@Kartiiyer12 Kartiiyer12 merged commit 0f2201d into cardano-foundation:master Nov 7, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants