-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added href to iconButton #18283
fix: added href to iconButton #18283
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 You just have to run yarn test -u
to update the snapshots.
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4f34117
to
86c191f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18283 +/- ##
=======================================
Coverage 84.15% 84.15%
=======================================
Files 406 406
Lines 14407 14407
Branches 4636 4690 +54
=======================================
Hits 12124 12124
+ Misses 2119 2118 -1
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that's not clear to me, and maybe I should've mentioned it in my review, is how adding this href
attribute is going to fix the type issues for rel
and target
attributes. If you delete the href
attribute in the reproduction, the type error just moves down to the next untyped prop which is target
. With that being said, are there more changes that should be made here?
424f22e
Closes #17955
Added href to iconButton
Changelog
New
-Added href to iconButton
Testing / Reviewing
Try using IconButton in .tsx file it should work as intended and should not show any typescript error.