fix: word counter position when text area have cols #18282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18282 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 404 404
Lines 14359 14359
Branches 4626 4660 +34
=======================================
Hits 12107 12107
Misses 2089 2089
Partials 163 163 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
approved these changes
Jan 2, 2025
2nikhiltom
approved these changes
Jan 3, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jan 3, 2025
853df59
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16791
Word Counter is correctly placed with textarea element when user passes cols property
Changelog
Changed
Testing / Reviewing
Pass cols prop in Textarea component
Keep changing the cols value , the word counter should not be fixed at corner out of textArea