Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(17525): fixes a11y violation in toggle #18216

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix(17525): fixes a11y violation in toggle #18216

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3756ac
fix(17525): fixes a11y violation in toggle
2nikhiltom Dec 9, 2024
5dc7e22
Merge branch 'main' into 17525_toggle_a11y
2nikhiltom Dec 9, 2024
d895310
Merge branch 'main' into 17525_toggle_a11y
2nikhiltom Dec 10, 2024
e070530
Merge branch 'main' into 17525_toggle_a11y
tay1orjones Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react/src/components/Toggle/Toggle.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,17 @@ export const WithAccessibleLabels = () => (
<div id="toggle-6-label" style={{ marginBlockEnd: '0.5rem' }}>
Internal aria-label toggle
</div>
<Toggle aria-label="Internal aria-label toggle" id="toggle-6" hideLabel />
<Toggle aria-labelledby="toggle-6-label" id="toggle-6" />
</div>

<div>
<label
id="toggle-7-label"
htmlFor="toggle-7"
style={{ display: 'block', marginBlockEnd: '0.5rem' }}>
External toggle label
</label>
<Toggle id="toggle-7" hideLabel />
<Toggle aria-labelledby="toggle-7-label" id="toggle-7" />
</div>
</VStack>
);
Expand Down
Loading