fix(tile): update clickable tile icon size and spacing #18068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18068 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4619 4599 -20
=======================================
Hits 12077 12077
- Misses 2111 2112 +1
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
requested review from
a team and
cameroncalder
and removed request for
a team
alisonjoseph
approved these changes
Nov 13, 2024
|
I think there was a prettier update. Might need to yarn install and yarn format to fix ci. |
emyarod
force-pushed
the
17776-fix/clickable-tile-icon-sizing
branch
from
f6a5f81 to
5af0d7e
Compare
|
my prettier was already up to date. there is something in our precommit scripts that is overwriting the formatter before pushing and I can't figure it out... |
riddhybansal
approved these changes
Nov 14, 2024
emyarod
force-pushed
the
17776-fix/clickable-tile-icon-sizing
branch
from
5af0d7e to
2e18b98
Compare
guidari
approved these changes
Nov 14, 2024
riddhybansal
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17776
This PR updates the clickable tile icon size and spacing to match the Figma spec
Changelog
Changed
Testing / Reviewing
confirm the clickable tile matches the design spec