-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PSR Capacity and Transmission Capacity #99
base: main
Are you sure you want to change the base?
Update PSR Capacity and Transmission Capacity #99
Conversation
Update endpoint schema to improve readibility Signed-off-by: Andre <[email protected]>
Signed-off-by: Andre <[email protected]>
Signed-off-by: Andre <[email protected]>
I think I'd prefer the unit to be at the top level, it makes it much easier to ingest the data if all of it is coming with the same unit on each call. |
in terms of readiblity I totally agree with you, but I was worried on how to manage it in PSRs that represent balancing areas where we can have varying magnitudes from nuclear power plants to local solar farms, for instance |
Maybe we just default to MWh? Most solar farms would be on the order of magnitude of 1 MWh, and a nuclear plant would only be in the thousands then right? |
- `technology` - _string_ - (OPTIONAL) - *id* of the technology for generating this fuel. | ||
- `type` - _string_ - (REQUIRED) - *id* of the fuel type used for generation. | ||
- `unit` - _string_ - (REQUIRED) - For electricity, **should** be one of: [`MW`, `kW`, `W`] | ||
- `capacity` - _Array_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also now thinking that we should possibly have separate arrays, one for "capacity" and one for "historical capacity", as I think a very common use case would be to just get the current capacity, so itd be nice to have an easy way to do that.
This PR solves the problem stated at #98
Proposed solution for PSR Capacity
New response object proposed :
fuelSource
: A list of the different fuel sourcesunit
is now individual for eachfuelSource
: Different generating plants might have different magnitudes.capacity
for eachFuelSource
: Historical updates are clearly identified with their correspondingfuelSource
.i.e:
The proposed example shows two producing units:
Proposed update for PSR Transmission Capacity
unit
should be individual for eachtransmissionCapacity
: Different interconnections might have different magnitudes.