Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

St maps #156

Closed
wants to merge 37 commits into from
Closed

St maps #156

wants to merge 37 commits into from

Conversation

andy6a
Copy link
Contributor

@andy6a andy6a commented Jan 17, 2024

Add new and improved visuals for a variety of situational uses when assessing sourcetracker results. Adjustments to readme for current archive location.

@cherman2 cherman2 self-assigned this Jan 23, 2024
README.md Show resolved Hide resolved
sourcetracker/_cli/gibbs.py Show resolved Hide resolved
sourcetracker/_cli/gibbs.py Show resolved Hide resolved
sourcetracker/_cli/gibbs.py Outdated Show resolved Hide resolved
sourcetracker/_plot.py Outdated Show resolved Hide resolved
sourcetracker/_plot.py Show resolved Hide resolved
sourcetracker/_plot.py Show resolved Hide resolved
sourcetracker/_plot.py Show resolved Hide resolved
@cherman2
Copy link
Collaborator

cherman2 commented Jan 31, 2024

Looks like there are some import issues. @andy6a Could you take a look at those?
Screenshot 2024-01-31 at 3 26 35 PM

@andy6a
Copy link
Contributor Author

andy6a commented Feb 1, 2024

Hey Chloe, I have 2 options here, first is I can just pull those lines out for now as there is no plot_heatmap anymore (although you were already having issues getting plots made so I am unsure as to the functionality here.) The second option is to try to modify to my new heatmap but I don't know how that would work. Let me know which you prefer!

@cherman2
Copy link
Collaborator

cherman2 commented Feb 1, 2024

I think option one of removing those imports makes the most sense to me.

@andy6a
Copy link
Contributor Author

andy6a commented Feb 20, 2024

Hey Chloe added the new function. Let me know what you think

@andy6a
Copy link
Contributor Author

andy6a commented Mar 4, 2024

Closing in favor of splitting pull request into upgraded plots and new plots function seperately

@andy6a andy6a closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants