Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage mount ownership update process during charm upgrades #200

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

weiiwang01
Copy link
Collaborator

Currently, when updating the storage mount ownership during the upgrade-charm event, the WordPress charm does not account for situations where pebble is not ready. This means that if the upgrade-charm event is fired before wordpress-pebble-ready, it will cause an error. To avoid this problem, update the process for updating storage ownership.

@weiiwang01 weiiwang01 requested a review from a team as a code owner March 15, 2024 15:39
@weiiwang01 weiiwang01 added the trivial This is a trivial PR label Mar 15, 2024
Copy link
Contributor

Test coverage for df7430c

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          540     35    184     33    91%   162, 203-206, 370, 429->433, 582, 613, 619, 636-640, 670, 705-706, 764, 773, 877->890, 889, 891, 896-897, 957, 975, 982, 1072, 1081, 1093, 1114, 1123, 1142, 1146, 1175, 1228, 1360, 1382, 1389->1391, 1434->exit, 1446, 1456, 1494
src/cos.py             21      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/state.py           34      0      4      0   100%
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 628     36    190     34    91%

Static code analysis report

Run started:2024-03-15 15:50:25.311447

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4584
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit 4776a67 into main Mar 22, 2024
36 checks passed
@weiiwang01 weiiwang01 deleted the fix-mount-ownership branch March 22, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants