refactor: use init command from craft-application #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
commented
Oct 23, 2024
mr-cal
force-pushed
the
work/CRAFT-3543/init-command
branch
4 times, most recently
from
c11a314
to
d235c56
Compare
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3543/init-command
branch
from
d235c56
to
57d4325
Compare
mr-cal
commented
Oct 23, 2024
tigarmo
approved these changes
Oct 24, 2024
tigarmo
reviewed
Oct 24, 2024
tigarmo
reviewed
Oct 24, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
dariuszd21
approved these changes
Nov 7, 2024
tigarmo
reviewed
Nov 8, 2024
tigarmo
reviewed
Nov 8, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
3 tasks
Signed-off-by: Callahan Kovacs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Replace Snapcraft's
initimplementation with craft-application's implementation. Somehow I added more lines of code 🙃There are no behavioral changes with just
snapcraft init. However, the command now accepts additional parameters added in craft-application:name,profile, andproject-dir.Fixes #5098
(CRAFT-3543)