-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use UV for dependency management #262
Conversation
3e65510
to
6f083ca
Compare
3640510
to
4dafdfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could expand on the PR description with a rationale. Plus, this PR does much more than add uv for dependency management. It also replaces dependabot with renovate, it introduces concierge for setting up the integration tests environment, it replaces the rust build package with a build snap. This is a pretty major change and a proper description would be useful to review it.
Good point, I updated the description with the rationale for each change. |
b8b4ef8
to
db8cd91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :) assuming renovate creates security PRs automatically.
One thing I am missing is to modify this file to allow the PRs to be auto-approved and merged. (Or at least let's remove that file)
db8cd91
to
d7b37ee
Compare
Good point, I removed the file and enabled Renovate's automerge. I also set the repository settings for Renovate to be able to bypass approval. |
Addressed requested changes
Description
Use
uv
for dependency management. Doing so, additional changes were required:uv
action-operator
withconcierge
, because the former insists on installingtox
with no way of disabling it, and we need to install tox differently to supportuv
rustup
snap to install the latest stable Rust compiler, required for some newer dependencies that do not build anymore with the version in the apt repository.Checklist: