Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use UV for dependency management #262

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

ghislainbourgeois
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois commented Oct 30, 2024

Description

Use uv for dependency management. Doing so, additional changes were required:

  • Replace Dependabot with Renovate, as the former does not support uv
  • Replace action-operator with concierge, because the former insists on installing tox with no way of disabling it, and we need to install tox differently to support uv
  • Install rustup snap to install the latest stable Rust compiler, required for some newer dependencies that do not build anymore with the version in the apt repository.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois force-pushed the chore-cc005 branch 2 times, most recently from 3e65510 to 6f083ca Compare October 30, 2024 17:23
@ghislainbourgeois ghislainbourgeois force-pushed the chore-cc005 branch 2 times, most recently from 3640510 to 4dafdfe Compare November 8, 2024 00:53
@ghislainbourgeois ghislainbourgeois marked this pull request as ready for review November 8, 2024 01:36
@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner November 8, 2024 01:36
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could expand on the PR description with a rationale. Plus, this PR does much more than add uv for dependency management. It also replaces dependabot with renovate, it introduces concierge for setting up the integration tests environment, it replaces the rust build package with a build snap. This is a pretty major change and a proper description would be useful to review it.

pyproject.toml Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@gruyaume gruyaume requested a review from a team November 8, 2024 11:46
@ghislainbourgeois
Copy link
Contributor Author

I think we could expand on the PR description with a rationale. Plus, this PR does much more than add uv for dependency management. It also replaces dependabot with renovate, it introduces concierge for setting up the integration tests environment, it replaces the rust build package with a build snap. This is a pretty major change and a proper description would be useful to review it.

Good point, I updated the description with the rationale for each change.

Copy link
Contributor

@saltiyazan saltiyazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :) assuming renovate creates security PRs automatically.
One thing I am missing is to modify this file to allow the PRs to be auto-approved and merged. (Or at least let's remove that file)

@ghislainbourgeois
Copy link
Contributor Author

This looks good :) assuming renovate creates security PRs automatically. One thing I am missing is to modify this file to allow the PRs to be auto-approved and merged. (Or at least let's remove that file)

Good point, I removed the file and enabled Renovate's automerge. I also set the repository settings for Renovate to be able to bypass approval.

@ghislainbourgeois ghislainbourgeois dismissed saltiyazan’s stale review November 13, 2024 00:35

Addressed requested changes

@ghislainbourgeois ghislainbourgeois merged commit 3423574 into main Nov 13, 2024
11 checks passed
@ghislainbourgeois ghislainbourgeois deleted the chore-cc005 branch November 13, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants