-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use TLS library v4 #206
Conversation
Signed-off-by: guillaume <[email protected]>
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through it and it looks really good. I have a few comments some of which might not be directly on the PR but I think they could be included here.
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I created tickets for the comments that would not be addressed as part of this PR.
For the comment on get_certificate_extensions
I prefer a better name, but I'll leave it up to you to resolve the comment either accepting or rejecting the new suggestion.
Signed-off-by: guillaume <[email protected]>
Description
Bump the TLS library to V4.
Addition of certificate helper methods
The addition of
src/certificates.py
is because the TLS libraryV4
does not provide thegenerate_certificate
,generate_private_key
, andgenerate_ca
helpers as those were specific to this self-signed certificates charm.Checklist: