fix: generate new ca cert on config changed #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug where on ca common name config changed, the self-signed certificates charm would generate a new CA, store it in a secret but we would read the secret in the same event handler and it would be the old secret.
Now, we return after changing the root CA certificate and updating the secret and we observe the "secret_changed" event. This allows for reading the new ca certificate instead of reading the old one.
Fixes #132
Checklist: