Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secret expiry in _generate_root_certificate #214

Closed
saltiyazan opened this issue Aug 8, 2024 · 0 comments · Fixed by #218
Closed

Fix secret expiry in _generate_root_certificate #214

saltiyazan opened this issue Aug 8, 2024 · 0 comments · Fixed by #218
Labels
bug Something isn't working

Comments

@saltiyazan
Copy link
Contributor

Bug Description

_generate_root_certificate uses _config_certificate_validity to set the expiry of the secret of the root CA while it should use _config_root_ca_certificate_validity

To Reproduce

Code here: https://github.com/canonical/self-signed-certificates-operator/blob/main/src/charm.py#L180

Environment

NA

Relevant log output

NA

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fixes secret expiry to use the correct config value canonical/self-signed-certificates-operator
1 participant
@saltiyazan