Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update base to 22.04 #19

Merged
merged 2 commits into from
Mar 22, 2024
Merged

chore: Update base to 22.04 #19

merged 2 commits into from
Mar 22, 2024

Conversation

ghislainbourgeois
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois commented Mar 21, 2024

Description

This updates the base to 22.04 and fixes the build of BESS.

The following changes were necessary to have the build complete:

  • Bump the base to Ubuntu 22.04
  • Bump Ubuntu packages that changed version in this release
  • Ignore some compiler warnings that were now treated as errors (the build system sets the flag to treat all warnings as errors, and the newer version of gcc introduced new warnings. Those will need to be fixed eventually upstream)
  • Change the linking from static to dynamic (with static linking, bess built properly but linking failed, and after many hours, I could not fix it)
  • Stage a lot of library packages, as the dynamic libraries now need to present in the image due to the change to dynamic linking
  • Set LD_LIBRARY_PATH in the image for the dynamic linker to find the custom dependencies (xdp, cndp and dpdk)

This rock was tested with the current beta release of Charmed-5G.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ghislainbourgeois ghislainbourgeois marked this pull request as ready for review March 21, 2024 22:26
@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner March 21, 2024 22:26
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved mostly on trust, it's hard to understand. Maybe a bit more information on the PR description would help. In any case, good job it's great to see this update. Turns out we won't have to plan this at all for 24.10.

rockcraft.yaml Show resolved Hide resolved
rockcraft.yaml Show resolved Hide resolved
@ghislainbourgeois
Copy link
Contributor Author

Approved mostly on trust, it's hard to understand. Maybe a bit more information on the PR description would help. In any case, good job it's great to see this update. Turns out we won't have to plan this at all for 24.10.

@gruyaume good point on the additional information, I updated the description to explain the different changes and a bit of reasoning.

@ghislainbourgeois ghislainbourgeois requested a review from a team March 22, 2024 01:01
@ghislainbourgeois ghislainbourgeois merged commit 514c62c into main Mar 22, 2024
7 checks passed
@ghislainbourgeois ghislainbourgeois deleted the update-22.04 branch March 22, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants