Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null error when deleting subscriber #413

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

patriciareinoso
Copy link
Contributor

Description

fix #412

The imsis field of a new NS that has never had a subscriber associated is null
When a NS has already had a subscriber associated the field is []
We were assuming that this field was always [] so it failed trying to access a null value. In consequence the subscriber was not entirely deleted.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@patriciareinoso patriciareinoso requested a review from a team as a code owner March 12, 2024 09:30
@patriciareinoso patriciareinoso force-pushed the TELCO-1053-delete-subscriber-bug branch from 6a4ee6d to 7426669 Compare March 12, 2024 09:58
@patriciareinoso patriciareinoso merged commit 2a8e960 into main Mar 12, 2024
8 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1053-delete-subscriber-bug branch March 12, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If there are multiple slices, subscribers data could not be deleted from the MongoDB.
2 participants