Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix rocks terminology #23

Merged
merged 1 commit into from
May 24, 2024
Merged

chore: fix rocks terminology #23

merged 1 commit into from
May 24, 2024

Conversation

cjdcordeiro
Copy link
Contributor

Description

Replace "ROCK" with "rock"

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@cjdcordeiro cjdcordeiro requested a review from a team as a code owner May 23, 2024 07:16
@gatici
Copy link
Contributor

gatici commented May 23, 2024 •
edited
Loading

Hello @cjdcordeiro,
All commits are expected to be GPG signed.(https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) But they are not GPG verified yet. Could you please sing it ? This comment is also valid for the PRs in other repositories.

@cjdcordeiro cjdcordeiro force-pushed the ROCKS-1171/fix-rocks-terminology branch 2 times, most recently from 6f1fa4a to 2bb3666 Compare May 24, 2024 08:04
@cjdcordeiro cjdcordeiro force-pushed the ROCKS-1171/fix-rocks-terminology branch from 2bb3666 to 5431e09 Compare May 24, 2024 08:06
@cjdcordeiro
Copy link
Contributor Author

ack and done @gatici

@gatici gatici merged commit ae6d986 into canonical:main May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjdcordeiro @gatici