Enter blocked status if resource and snap_channel #115
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelallan72
requested review from
Pjack,
aieri,
jneo8,
gabrielcocenza,
rgildein,
Deezzir and
chanchiwai-ray
When a resource is used, the `snap_channel` config option is ignored. In this case, the snap is installed directly from the resource file, so a "channel" doesn't make sense. If `snap_channel` is set and a resource is being used, it may indicate a confusion situation, such as the user changing the `snap_channel` and wondering why the snap isn't being updated. So the charm can alert the user to this situation via a message and blocked status. Fixes: #113
samuelallan72
force-pushed
the
block-snap_channel_resource
branch
from
b7c40db to
67fde95
Compare
gabrielcocenza
previously approved these changes
Oct 21, 2024
jneo8
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource is used, the
snap_channelconfig option is ignored. In this case, the snap is installed directly from the resource file, so a "channel" doesn't make sense.If
snap_channelis set and a resource is being used, it may indicate a confusion situation,such as the user changing the
snap_channeland wondering why the snap isn't being updated.
So the charm can alert the user to this situation
via a message and blocked status.
Fixes: #113