decision: up-alert-rules #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Nov 12, 2024
| Metrics not received from host '{{ $labels.instance }}'. This is likely due to an issue with an itermediate metrics agent. | ||
| ``` | ||
|
|
||
| ## Rationale |
There was a problem hiding this comment.
In the rationale we should explicitly address:
- Why per charm and not just once in prometheus / mimir?
- Should
upalert be in prom andabsentper charm? - How should aggregators such as gagent go about this. See also
up < 1 or absent(up)in feat(alerting): detect flapping alerts grafana-agent-operator#148. - Scrape failed is different from host didn't send data.
- Missing of scrape targets vs missing of self, see https://github.com/canonical/prometheus-k8s-operator/blob/main/src/prometheus_alert_rules/prometheus_missing.rule
|
Hey @dstathis |
| - name: HostHealth | ||
| rules: | ||
| - alert: HostUnreachable | ||
| expr: up < 1 |
There was a problem hiding this comment.
Is this not a duplicate of the HostDown expression?
There was a problem hiding this comment.
Nope. Difference is the "for" field and the severity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up-alert-rules ADR