Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tls-certificates v3 #82

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Use tls-certificates v3 #82

merged 4 commits into from
Mar 26, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Mar 26, 2024

Issue

Certificates generated by the charm don't include intermediates: canonical/httprequest-lego-k8s-operator#93.

Solution

This was addressed by canonical/tls-certificates-interface#141 in v3, but wasn't back-ported to v2, so bump to v3.

Technically the diff presents a breaking change for the .chain property, but we haven't really used it anywhere yet.

In tandem with:

Upgrade notes

Due to this diff:

-if chain := self._peer_relation.data[self.charm.unit].get("chain", []):
+if chain := self._peer_relation.data[self.charm.unit].get("chain", ""):

on charm upgrade, the new charm would be expecting a str, but peer data would hold a List[str]. For this reason, first unrelate (tls_certificates), upgrade, and then relate again.

Copy link
Contributor

@Abuelodelanada Abuelodelanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use TLSCertificatesRequiresV3 in cert_handler v1 too?

@sed-i
Copy link
Contributor Author

sed-i commented Mar 26, 2024

Shouldn't we use TLSCertificatesRequiresV3 in cert_handler v1 too?

I didn't bump cert_handler, it's still at v0.

@Abuelodelanada Abuelodelanada self-requested a review March 26, 2024 19:29
@sed-i sed-i merged commit f2060ea into main Mar 26, 2024
13 checks passed
@sed-i sed-i deleted the feature/tls-v3 branch March 26, 2024 20:32
@sed-i sed-i mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants