Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use loki_push_api v1 #459

Merged
merged 2 commits into from
Sep 19, 2024
Merged

use loki_push_api v1 #459

merged 2 commits into from
Sep 19, 2024

Conversation

Abuelodelanada
Copy link
Contributor

Issue

Now we use loki_push_api v1....

Context

While working on #455 and canonical/grafana-agent-operator#185 I've found that we were using v0 of the lib

@Abuelodelanada Abuelodelanada requested a review from a team as a code owner September 18, 2024 23:27
lucabello
lucabello approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@lucabello lucabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please fix itests and maybe manually test things as well :)

@Abuelodelanada
Copy link
Contributor Author

Approving, but please fix itests and maybe manually test things as well :)

Now are green ;-)

@Abuelodelanada Abuelodelanada merged commit bf4d760 into main Sep 19, 2024
13 checks passed
@Abuelodelanada Abuelodelanada deleted the loki_push_api_version branch September 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucabello lucabello lucabello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abuelodelanada @lucabello