Update tools/get-images.sh to handle both Go and Python versions of yq #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgildein
previously approved these changes
Aug 29, 2024
|
(discussed during the daily) The CI is currently blocked because of canonical/charmcraft#1845 |
kimwnasptd
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #562
This PR updates
tools/get-images.shto be version agnostic when it comes to theyqutility. There is additional context in the issue's description.From experimentation, the Python version of
yqalso adds quotes to the output, sotris called to remove any quote characters from all the entries.To test:
bash tools/get-images.shwith the snap version ofyq(installed viasudo snap install yq)bash tools/get-images.shwith the Python verison ofyq(installed viapip install yq)bash tools/get-images.shin themainbranch.