Add annotations for configuring which devices cilium use for routing #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Oct 14, 2024
HomayoonAlimohammadi
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks a lot @berkayoz! LGTM. Just some minor nit comments.
berkayoz
force-pushed
the
KU-1783/cilium-devices
branch
from
c2a89cf
to
d75ac08
Compare
mateoflorido
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702
Cilium excludes
bridgedevices while performing auto detection and suggests providing the selection filtermanually through thedevicesflag if auto detection is not suitable.This PR adds the
k8sd/v1alpha1/cilium/devicesandk8sd/v1alpha1/cilium/direct-routing-deviceannotations to let users configure which devices(interfaces) can be used by cilium.Initially we aimed to override this auto detection and select the device based on the node internal ip however the device names could be different on multiple machines which breaks this assumption. As an alternative we could set the
devicesfield with a certain default value with wildcard filters to cover common interface names, e.g.eth+ lxdbr+ enp+.