Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport-1.18): Pin charmcraft channel to 3.x/stable #547

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Sep 3, 2024

This PR is a backport that is part of closing this issue.

It pins the channel used in our CI from latest/candidate to 3.x/stable.

Ideally we can unpin the version when this issue is fixed.

* Pin charmcraft channel

* Add comment above the pinning to link to the proper issue

* Pin to 3.x instead of 3.1 which doesn't exist as a track
@mvlassis mvlassis requested a review from a team as a code owner September 3, 2024 13:57
@mvlassis mvlassis changed the base branch from main to track/1.18 September 3, 2024 14:00
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvlassis mvlassis merged commit 187cf73 into track/1.18 Sep 4, 2024
19 checks passed
@mvlassis mvlassis deleted the backport-1.18-kf-6195-pin-charmcraft-version branch September 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants