Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick fix from 3.2 and add changelog item for 3.3.1 #2110

Merged
merged 2 commits into from
Jan 24, 2025
Merged

chore: cherry-pick fix from 3.2 and add changelog item for 3.3.1 #2110

merged 2 commits into from
Jan 24, 2025

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jan 23, 2025 •
edited
Loading

  • Cherry-picks @cmatsuoka 's fix for 3.2.3
  • Adds an incomplete changelog for 3.3.1

@lengau lengau added the rebase label Jan 23, 2025
@lengau lengau requested review from cmatsuoka and mr-cal January 23, 2025 19:22
@lengau lengau requested a review from medubelko as a code owner January 23, 2025 19:22
@lengau lengau marked this pull request as draft January 23, 2025 19:48
cmatsuoka and others added 2 commits January 23, 2025 15:41
@cmatsuoka @lengau
fix(commands/test): add experimental notice to command (#2108)
8202e81 
The test command is experimental and was not intended to reach stable
releases. Place a notice on command help and execution. This command
will be removed and replaced by the final implementation that will
exist in craft-application.

Signed-off-by: Claudio Matsuoka <[email protected]>
@lengau
docs(changelog): add changelog for 3.3.1
57dd2fd
@lengau lengau force-pushed the work/3.3-test-experimental branch from 465aefd to 57dd2fd Compare January 23, 2025 20:42
@lengau
Copy link
Collaborator Author

lengau commented Jan 23, 2025

Force-pushed after rebasing on #2106

@lengau lengau changed the title chore: cherry-pick fix from 3.2 and add changelog for 3.3.1 chore: cherry-pick fix from 3.2 and add changelog item for 3.3.1 Jan 23, 2025
@lengau lengau marked this pull request as ready for review January 23, 2025 20:44
@lengau lengau merged commit 3ed2982 into hotfix/3.3 Jan 24, 2025
28 checks passed
@lengau lengau deleted the work/3.3-test-experimental branch January 24, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@medubelko medubelko medubelko approved these changes

@sergiusens sergiusens sergiusens approved these changes

@cmatsuoka cmatsuoka Awaiting requested review from cmatsuoka

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lengau @sergiusens @medubelko @mr-cal @cmatsuoka