test: various misc changes #81
Open
Commits on Oct 25, 2024
-
test: use onlyImage() from cockpit test lib
Use the onlyImage() decorator provided by the test lib of cockpit, replacing the usage of our own skipUnlessDistroFamily(). There is no behaviour change.
-
test: upload product certificates to /etc/pki/product-default
That is their canonical location.
-
test: drop extra activation key code
The Python snippet to add a pool to an activation key in practice does not work anymore for two reasons: 1) the test data in the self-deployed Candlepin changed 2) the test account used is based on SCA and the result of the last POST in the script is: { "displayMessage" : "Multi-entitlement not supported for pool \"Pool [id: 8a8082e491b0fb160191b0fb37e20233, type: NORMAL, product: sfs, productName: Shared File System, quantity: 5]\"", "requestUuid" : "8e43664e-e720-4cb8-8a99-bfe3cd49af2c" } Especially because of (2), it is possible to get rid of the script altogether, and simply use the available activation keys. There is no behaviour change. -
test: use curl directly to wait for Candlepin
Instead of running a Python script to wait for Candlepin to start, use curl to do the busy-wait loop. Keep the initial delay as-is, performing it inline. There should be no behaviour changes.
-
test: use f-strings to replace other string formattings
Use f-strings to replace C-like placeholders and format() calls. There is no behaviour change.
-
test: use a simpler way to append content to a file
Use the existing API of a cockpit Machine, rather than running a shell command manually. There is no behaviour change.
-
test: drop no more used machine_python() helper function
There are no more Python scripts to run as part of the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.