Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cockpit test lib to 323 #79

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

ptoscano
Copy link
Collaborator

This requires a couple of adaptations in the actual test script:

  • make use of the pywrap script available in cockpit's test/common to import all the right modules for us (removing the manual imports)
  • tweak the import of testvm to be done like done in cockpit tests

There should be no behaviour changes.

This requires a couple of adaptations in the actual test script:
- make use of the "pywrap" script available in cockpit's "test/common"
  to import all the right modules for us (removing the manual imports)
- tweak the import of "testvm" to be done like done in cockpit tests

There should be no behaviour changes.
Copy link
Contributor

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thanks, and I'm glad that this was so painless.

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit 623d454 into main Aug 20, 2024
6 checks passed
@jirihnidek jirihnidek deleted the ptoscano/bump-cockpit-to-323 branch August 20, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants