FUSETOOLS2-2371: provide workaround to install VS Code extensions with #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
2308-FixMainBranchTestOnWindows
branch
from
d5e480f
to
695e89c
Compare
apupier
commented
May 2, 2024
| @@ -46,7 +47,8 @@ async function main(): Promise<void> { | |||
| function installExtraExtension(cliPath: string, extensionId: string, args: string[]) { | |||
| cp.spawnSync(cliPath, [...args, '--install-extension', extensionId, '--force'], { | |||
| encoding: 'utf-8', | |||
| stdio: 'inherit' | |||
| stdio: 'inherit', | |||
| shell: os.platform() === 'win32' // to workaround https://github.com/nodejs/node/issues/52554#issuecomment-2060026269 | |||
There was a problem hiding this comment.
another option would be to provide always true and escape spaces for MacOS for the vscode executable path
djelinek
approved these changes
May 2, 2024
latest Node security release see nodejs/node#52554 (comment) Applying it on Windows only otherwise it is breaking MacOS with error: `/bin/sh: /Users/runner/work/vscode-camelk/vscode-camelk/.vscode-test/vscode-darwin-arm64-1.85.2/Visual: No such file or directory` Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
2308-FixMainBranchTestOnWindows
branch
from
695e89c
to
0c01328
Compare
apupier
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest Node security release
see nodejs/node#52554 (comment)