Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Open in new tab' breaks on ca-nav tabs #110

Open
nealeu opened this issue Apr 16, 2018 · 2 comments
Open

'Open in new tab' breaks on ca-nav tabs #110

nealeu opened this issue Apr 16, 2018 · 2 comments

Comments

@nealeu
Copy link
Member

nealeu commented Apr 16, 2018

This is broken on many levels. Ultimately it would be better to have something based on app-router, but for now, lets at least not use <a href> where it doesn't work.

Will need to check accessibility on this too.

@tapina
Copy link
Contributor

tapina commented Apr 16, 2018

There’s a better nav using app-router used in the taas-admin-ui (non-public) project.

@nealeu
Copy link
Member Author

nealeu commented Apr 16, 2018

Perhaps worth superceding. app-router looks a far better basis. Maybe deprecate this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants